Require IDs to be unique (even with drafts) #3185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is table setting for web-platform-dx#2666 and web-platform-dx#2339 and web-platform-dx#2341. Before this, it was possible to have a draft feature shadow the ID of a published feature. This change improves the safety of moving features from draft to published (and vice versa). While we don't have draft groups or snapshots, I checked these too since it seemed weird and incomplete not too.
foolip
approved these changes
Aug 11, 2025
|
|
||
| // Assert ID uniqueness | ||
| for (const [pool, map] of Object.entries(uniqueIdMaps)) { | ||
| if (!pathParts.includes("spec") && pathParts.includes(pool)) { |
There was a problem hiding this comment.
Is the !pathParts.includes("spec") condition about the features/draft/spec/ directory? If so, should we instead give all drafts the same treatment? We set data[draft] in this loop so we might be able to use that in the condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is table setting for #2666 and #2339 and #2341.
Before this, it was possible to have a draft feature shadow the ID of a published feature. This change improves the safety of moving features from draft to published (and vice versa).
While we don't have draft groups or snapshots, I checked these too since it seemed weird and incomplete not too.